Skip to content

Conversation

@cpAdm
Copy link
Contributor

@cpAdm cpAdm commented Dec 30, 2025

Don't poll if the selected test is still selected. Wait for a response from the websocket instead that the test has started (that updates item prop). This polling fetch would fail (sw errors), causing the model to be set to a new TraceModel with an empty traceURI, which in case would make the source call fail (the original issue).

Added assertions to existing test.

Tried instead adding following assertions in runUITest fixture:

expect.soft((page && !page.isClosed()) ? await page.consoleMessages() : []).toHaveLength(0);
expect.soft((page && !page.isClosed()) ? await page.pageErrors() : []).toHaveLength(0);

However many would then fail:
snapshot action must have a pageId (10+ ui-mode tests; e.g. should not duplicate network entries from beforeAll)
Failed to load resource: the server responded with a status of 404 (Not Found) (should run folder / should merge trace events / should merge web assertion events / should show request source context id)

Closes: #38359

@cpAdm cpAdm requested a review from pavelfeldman January 7, 2026 18:03
Copy link
Member

@Skn0tt Skn0tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. The change looks good, but I wonder about the test.

@cpAdm cpAdm requested a review from Skn0tt January 18, 2026 14:22
@github-actions
Copy link
Contributor

Test results for "tests 1"

26 failed
❌ [chromium-library] › library/agent-expect.spec.ts:223 › expectURL success @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/agent-expect.spec.ts:261 › expectURL with regex @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/agent-expect.spec.ts:223 › expectURL success @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/agent-expect.spec.ts:261 › expectURL with regex @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/agent-expect.spec.ts:223 › expectURL success @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/agent-expect.spec.ts:261 › expectURL with regex @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/agent-expect.spec.ts:223 › expectURL success @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/agent-expect.spec.ts:261 › expectURL with regex @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @chromium-ubuntu-22.04-node22
❌ [firefox-library] › library/agent-expect.spec.ts:223 › expectURL success @firefox-ubuntu-22.04-node20
❌ [firefox-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @firefox-ubuntu-22.04-node20
❌ [firefox-library] › library/agent-expect.spec.ts:261 › expectURL with regex @firefox-ubuntu-22.04-node20
❌ [firefox-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @firefox-ubuntu-22.04-node20
❌ [webkit-library] › library/agent-expect.spec.ts:223 › expectURL success @webkit-ubuntu-22.04-node20
❌ [webkit-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @webkit-ubuntu-22.04-node20
❌ [webkit-library] › library/agent-expect.spec.ts:261 › expectURL with regex @webkit-ubuntu-22.04-node20
❌ [webkit-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @webkit-ubuntu-22.04-node20
❌ [playwright-test] › playwright.spec.ts:877 › page.pause() should disable test timeout @macos-latest-node20
❌ [playwright-test] › reporter.spec.ts:251 › merged › should not have internal error when steps are finished after timeout @macos-latest-node20

2 flaky ⚠️ [firefox-page] › page/workers.spec.ts:150 › should clear upon navigation `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:426 › should work behind reverse proxy `@macos-latest-node20`

34580 passed, 691 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "MCP"

1 failed
❌ [chromium] › mcp/launch.spec.ts:21 › test reopen browser @mcp-macos-15

2829 passed, 121 skipped


Merge workflow run.

@Skn0tt Skn0tt merged commit 77d0040 into microsoft:main Jan 21, 2026
19 of 32 checks passed
@cpAdm cpAdm deleted the fix-fetching-after-schedule branch January 21, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Source temporarily disappears when starting test

3 participants