-
Notifications
You must be signed in to change notification settings - Fork 5k
fix(ui): Wait with polling if test is still scheduled #38656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Skn0tt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review. The change looks good, but I wonder about the test.
Test results for "tests 1"26 failed 2 flaky34580 passed, 691 skipped Merge workflow run. |
Test results for "MCP"1 failed 2829 passed, 121 skipped Merge workflow run. |
Don't poll if the selected test is still selected. Wait for a response from the websocket instead that the test has started (that updates
itemprop). This polling fetch would fail (sw errors), causing the model to be set to a newTraceModelwith an emptytraceURI, which in case would make the source call fail (the original issue).Added assertions to existing test.
Closes: #38359